Re: [RFC] bisect: Introduce skip-when to automatically skip commits

From: Junio C Hamano <gitster@pobox.com>
Date: Apr 10, 2024, 19:31 UTC
Message-ID: <xmqqle5lrp46.fsf@gitster.g>
In-Reply-To: <bb0dc4a7-e598-45f5-b707-e22de0890f26@schinagl.nl>

Olliver Schinagl <oliver@schinagl.nl> writes:

> See, the hook is named 'post-checkout' and thus, it runs after
> checkout has been performed. So we are now on the 'broken' commit we
> do not want to test, git should have skipped this already, and not
> checked it out.

You are not the only user of this feature (by the way, do not call this a "hook". It should be per "git bisect" session) and others may need to actually inspect their working tree state before being able to say "nah, I do not want to test this version, please give me another one" by exiting with 125. That is why post-checkout is more useful in general. Contrasted with that, a check that happens before the checkout is useful only in a much narrower "I can tell by looking only at the commit object name" use case, which I would not be interested in seeing.

Thanks.