Re: [PATCH v4 1/2] repo: add level of concern reporting

From: Junio C Hamano <gitster@pobox.com>
Date: Oct 29, 2026, 19:53 UTC
Message-ID: <xmqqld7g1dy4.fsf@gitster.g>
In-Reply-To: <20261029-b4-repo-structure-concern-v4-1-d813537ec617@fastmail.com>

"Mark C. Chu-Carroll" <markchucarroll@fastmail.com> writes:

Show 9 quoted lines

> @@ -550,51 +700,76 @@ static void stats_table_setup_structure(struct stats_table *table,
>  	stats_table_object_size_addf(table,
>  				     &objects->largest.commit_size.oid,
>  				     objects->largest.commit_size.value,
> +				     repo_structure_concern_level(
> +					     CONCERN_STAT_COMMIT_LARGEST,
> +					     objects->largest.commit_size.value,
> +					     repo_structure_concern_thresholds),
>  				     "    * %s", _("Maximum size"));

So, objects->largest.commit_size is computed using the value in objects->largest.commit_size.value field.

Show 8 quoted lines

>  	stats_table_object_size_addf(table,
>  				     &objects->largest.tree_size.oid,
>  				     objects->largest.tree_size.value,
> +				     repo_structure_concern_level(
> +					     CONCERN_STAT_TREE_LARGEST,
> +					     objects->largest.commit_size.value,
> +					     repo_structure_concern_thresholds),
>  				     "    * %s", _("Maximum size"));

And the same objects->largest.commit_size.value is also used to compute objects->largest.tree_size here.

Copy and paste mistake, perhaps?

Please do not take this "review" to mean that this is the only glitch I spotted, or that I will advocate for its inclusion in 'next' once it is fixed. I am merely pointing out what I happened to notice while driving by.

I do not have a strong opinion for or against the feature itself, nor have I read the entire patch carefully.

Thanks.