Re: [PATCH v2 2/3] repo: make concern thresholds configurable
- From
Patrick Steinhardt <ps@pks.im>
- Date
- Oct 27, 2026, 14:55 UTC
- Message-ID
- <auC7XTg6YXl6xAM3@pks.im>
- In-Reply-To
- <20261026-b4-repo-structure-concern-v2-2-e0df34228dc8@fastmail.com>
On Mon, Oct 26, 2026 at 01:43:55PM -0400, Mark C. Chu-Carroll wrote:
Show 47 quoted lines
> diff --git a/builtin/repo.c b/builtin/repo.c
> index a450497d4e..ed579e6685 100644
> --- a/builtin/repo.c
> +++ b/builtin/repo.c
> @@ -386,40 +389,43 @@ enum concern_stat {
> CONCERN_STAT_TREE_INFLATED_SIZE,
> CONCERN_STAT_BLOB_INFLATED_SIZE,
> CONCERN_STAT_TAG_INFLATED_SIZE,
> + CONCERN_STAT_MAXIMUM
> };
>
> -struct concern_stat_threshold repo_structure_concern_thresholds[] = {
> - { .name = "commit_count", .threshold = 19 },
> - {.name = "tree_count", .threshold = 21 },
> - { .name = "blob_count", .threshold = 22 },
> - { .name = "tag_count", .threshold = 15 },
> - { .name = "commit_size", .threshold = 28 },
> - { .name = "tree_size", .threshold = 27 },
> - { .name = "blob_size", .threshold = 36 },
> - { .name = "tags_size", .threshold = 18 },
> - { .name = "commit_largest", .threshold = 18 },
> - { .name = "tree_largest", .threshold = 18 },
> - { .name = "blob_largest", .threshold = 26 },
> - { .name = "tag_largest", .threshold = 15 },
> - { .name = "commit_inflated_size", .threshold = 28 },
> - { .name = "tree_inflated_size", .threshold = 32 },
> - { .name = "blob_inflated_size", .threshold = 34 },
> - { .name = "tag_inflated_size", .threshold = 25}
> +struct concern_stat_threshold concern_stat_thresholds[] = {
> + { .name = "commit-count", .threshold = 19 },
> + { .name = "tree-count", .threshold = 21 },
> + { .name = "blob-count", .threshold = 22 },
> + { .name = "tag-count", .threshold = 15 },
> + { .name = "commit-size", .threshold = 28 },
> + { .name = "tree-size", .threshold = 27 },
> + { .name = "blob-size", .threshold = 36 },
> + { .name = "tag-size", .threshold = 18 },
> + { .name = "commit-largest", .threshold = 18 },
> + { .name = "tree-largest", .threshold = 18 },
> + { .name = "blob-largest", .threshold = 26 },
> + { .name = "tag-largest", .threshold = 15 },
> + { .name = "commit-inflated-size", .threshold = 28 },
> + { .name = "tree-inflated-size", .threshold = 32 },
> + { .name = "blob-inflated-size", .threshold = 34 },
> + { .name = "tag-inflated-size", .threshold = 25},
> + { 0 }
> };This commit seems to fix up a couple of issues introduced in the preceding commit. We generally require that every patch of a patch series should compile and pass all tests so that we can bisect our history.
Patrick