Re: [PATCH v4 1/2] repo: add level of concern reporting
- From
- Mark C. Chu-Carroll <markchucarroll@fastmail.com>
- Date
- Oct 29, 2026, 20:20 UTC
- Message-ID
- <DMHLN4FBDV5C.8O60G05LVV3@fastmail.com>
- In-Reply-To
- <xmqqld7g1dy4.fsf@gitster.g>
On Thu Oct 29, 2026 at 3:53 PM EDT, Junio C Hamano wrote:
Show 28 quoted lines
> "Mark C. Chu-Carroll" <markchucarroll@fastmail.com> writes:
>
>> @@ -550,51 +700,76 @@ static void stats_table_setup_structure(struct stats_table *table,
>> stats_table_object_size_addf(table,
>> &objects->largest.commit_size.oid,
>> objects->largest.commit_size.value,
>> + repo_structure_concern_level(
>> + CONCERN_STAT_COMMIT_LARGEST,
>> + objects->largest.commit_size.value,
>> + repo_structure_concern_thresholds),
>> " * %s", _("Maximum size"));
>
> So, objects->largest.commit_size is computed using the value in
> objects->largest.commit_size.value field.
>
>> stats_table_object_size_addf(table,
>> &objects->largest.tree_size.oid,
>> objects->largest.tree_size.value,
>> + repo_structure_concern_level(
>> + CONCERN_STAT_TREE_LARGEST,
>> + objects->largest.commit_size.value,
>> + repo_structure_concern_thresholds),
>> " * %s", _("Maximum size"));
>
> And the same objects->largest.commit_size.value is also used to
> compute objects->largest.tree_size here.
>
> Copy and paste mistake, perhaps?Argh, yeah. I road through this commit _so_ many times, and still managed to miss that. Grumble. Will, of course, fix.
-Mark
-- Mark Craig Chu-Carroll (@MarkChuCarroll at gitlab) *** Software Tools/Math Geek - Software Engineer at Gitlab *** Work Email: mcarroll@gitlab.com / markchucarroll@fastmail.com *** Personal Blog: http://goodmath.org/blog / Personal email: markcc@gmail.com