Re: [PATCH v3] git tag --contains: avoid stack overflow
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Sep 23, 2014, 22:41 UTC
- Message-ID
- <xmqqk34ugdtm.fsf@gitster.dls.corp.google.com>
- In-Reply-To
- <87wq8u3t4l.fsf@igel.home>
Andreas Schwab <schwab@linux-m68k.org> writes:
Show 10 quoted lines
> Jeff King <peff@peff.net> writes: > >> But if we do want to keep it, does bumping it to 128 (and bumping the >> 4000 to 8000 in the test below it) work? > > It works for all architectures supported by the openSUSE build service. > > https://build.opensuse.org/package/show/home:AndreasSchwab:f/git > > Andreas.
So this on top of cbc60b67 (git tag --contains: avoid stack overflow, 2014-04-24) and merge it to maint and upwards?
t/t7004-tag.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/t/t7004-tag.sh b/t/t7004-tag.sh index e4ab0f5..c564197 100755 --- a/t/t7004-tag.sh +++ b/t/t7004-tag.sh @@ -1424,7 +1424,7 @@ EOF ' run_with_limited_stack () { - (ulimit -s 64 && "$@") + (ulimit -s 128 && "$@") } test_lazy_prereq ULIMIT 'run_with_limited_stack true' @@ -1433,7 +1433,7 @@ test_lazy_prereq ULIMIT 'run_with_limited_stack true' test_expect_success ULIMIT '--contains works in a deep repo' ' >expect && i=1 && - while test $i -lt 4000 + while test $i -lt 8000 do echo "commit refs/heads/master committer A U Thor <author@example.com> $((1000000000 + $i * 100)) +0200