Re: [PATCH v2] git tag --contains : avoid stack overflow

From: Stepan Kasal <kasal@ucw.cz>
Date: Apr 23, 2014, 19:59 UTC
Message-ID: <20140423195957.GA3187@camelia.ucw.cz>
In-Reply-To: <xmqqeh0nzwq9.fsf@gitster.dls.corp.google.com>

Hi,

On Wed, Apr 23, 2014 at 12:12:14PM -0700, Junio C Hamano wrote:

> [Administrivia: please refrain from using Mail-Followup-To to
> deflect an attempt to directly respond to you;

thanks a lot for telling me. Actually, this was a mistake: I added git to the list of discussion lists, without realizing the consequences. I'm glad to have separate copies of "my threads" that do not fall to the git-list folder.

> > +>expect
> Move this inside test_expect_success?

Of course.  Had this in mind, then forgot.

> So this runs a separate "bash", [...]
> run "git tag" in the original shell?
> 
> Ahh, no, I am mis-pairing the quotes.

Point taken.  I admire how nicely you explained that!

> 	run_with_limited_stack () {
> 		"$SHELL_PATH" -c "ulimit -s 64 && $*"
> 	}

Elegant. But I agree with Peff that we shall run "a bash" instead.

I'll mail an updated patch tomorrow.

Stepan