Re: [PATCH v3] git tag --contains: avoid stack overflow

From: Jeff King <peff@peff.net>
Date: Apr 25, 2014, 05:54 UTC
Message-ID: <20140425055428.GA25337@sigill.intra.peff.net>
In-Reply-To: <20140424122439.GB8168@camelia.ucw.cz>

On Thu, Apr 24, 2014 at 02:24:39PM +0200, Stepan Kasal wrote:

Show 23 quoted lines

> From: Jean-Jacques Lafay <jeanjacques.lafay@gmail.com>
> 
> In large repos, the recursion implementation of contains(commit,
> commit_list) may result in a stack overflow. Replace the recursion with
> a loop to fix it.
> 
> This problem is more apparent on Windows than on Linux, where the stack
> is more limited by default.
> 
> See also this thread on the msysGit list:
> 
> 	https://groups.google.com/d/topic/msysgit/FqT6boJrb2g/discussion
> 
> [jes: re-written to imitate the original recursion more closely]
> 
> Thomas Braun pointed out several documentation shortcomings.
> 
> Tests are run only if ulimit -s is available.  This means they cannot
> be run on Windows.
> 
> Signed-off-by: Jean-Jacques Lafay <jeanjacques.lafay@gmail.com>
> Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
> Tested-by: Stepan Kasal <kasal@ucw.cz>

Thanks, this version looks good to me.

-Peff