Re: [PATCH 3/3] push: allow --follow-tags to be set by config push.followTags

From: Junio C Hamano <gitster@pobox.com>
Date: Mar 14, 2015, 22:08 UTC
Message-ID: <xmqqk2yjw7u1.fsf@gitster.dls.corp.google.com>
In-Reply-To: <alpine.DEB.2.11.1503141049080.16979@narbuckle.genericorp.net>

Dave Olszewski <cxreg@pobox.com> writes:

Show 27 quoted lines

> On Fri, 13 Mar 2015, Junio C Hamano wrote:
>
>> Jeff King <peff@peff.net> writes:
>> 
>> > From: Dave Olszewski <cxreg@pobox.com>
>> >
>> > Signed-off-by: Dave Olszewski <cxreg@pobox.com>
>> > ---
>> > Again, this is just a preview. Dave should send the final when he thinks
>> > it is good.
>> 
>> Dave?
>> 
>> I do not see anything wrong with this version that builds on top of
>> the previous 2 clean-up.  Personally I find that these clean-up
>> changes more valuable than I care about this particular feature, and
>> it is unfortunate that waiting an Ack or reroll of this one kept
>> them stalled.
>> 
>> I am tempted to throw "Helped-by: Peff" into the log message and
>> merge the result to 'next', unless I hear otherwise in a few days.
>
> Sorry, work has kept me very busy lately, I haven't had time to re-visit
> this.  Jeff's version looks great to me, please go ahead with it.
> Thanks everyone.
>
>     Dave

Thanks.