Re: [PATCH 3/3] push: allow --follow-tags to be set by config push.followTags
- From
Jeff King <peff@peff.net>
- Date
- Mar 14, 2015, 17:34 UTC
- Message-ID
- <20150314173424.GB32599@peff.net>
- In-Reply-To
- <xmqqh9toxgdd.fsf@gitster.dls.corp.google.com>
On Fri, Mar 13, 2015 at 11:06:22PM -0700, Junio C Hamano wrote:
Show 19 quoted lines
> Jeff King <peff@peff.net> writes: > > > From: Dave Olszewski <cxreg@pobox.com> > > > > Signed-off-by: Dave Olszewski <cxreg@pobox.com> > > --- > > Again, this is just a preview. Dave should send the final when he thinks > > it is good. > > Dave? > > I do not see anything wrong with this version that builds on top of > the previous 2 clean-up. Personally I find that these clean-up > changes more valuable than I care about this particular feature, and > it is unfortunate that waiting an Ack or reroll of this one kept > them stalled. > > I am tempted to throw "Helped-by: Peff" into the log message and > merge the result to 'next', unless I hear otherwise in a few days.
FWIW, as the author of the leadup patches, that would be fine with me. I think the end patch is in fine shape.
-Peff