git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 3/3] push: allow --follow-tags to be set by config push.followTags

From
Jeff King <peff@peff.net>
Date
Mar 14, 2015, 17:34 UTC
Message-ID
<20150314173424.GB32599@peff.net>
In-Reply-To
<xmqqh9toxgdd.fsf@gitster.dls.corp.google.com>
On Fri, Mar 13, 2015 at 11:06:22PM -0700, Junio C Hamano wrote:
Show 19 quoted lines
> Jeff King <peff@peff.net> writes:
> 
> > From: Dave Olszewski <cxreg@pobox.com>
> >
> > Signed-off-by: Dave Olszewski <cxreg@pobox.com>
> > ---
> > Again, this is just a preview. Dave should send the final when he thinks
> > it is good.
> 
> Dave?
> 
> I do not see anything wrong with this version that builds on top of
> the previous 2 clean-up.  Personally I find that these clean-up
> changes more valuable than I care about this particular feature, and
> it is unfortunate that waiting an Ack or reroll of this one kept
> them stalled.
> 
> I am tempted to throw "Helped-by: Peff" into the log message and
> merge the result to 'next', unless I hear otherwise in a few days.

FWIW, as the author of the leadup patches, that would be fine with me. I think the end patch is in fine shape.

-Peff
Previous: Junio C HamanoNext: Dave Olszewski
Message 25 of 29 in “push: allow --follow-tags to be set by config push.followTags”
  1. push: allow --follow-tags to be set by config push.followTagsDave Olszewski, Feb 16, 2015
  2. Jeff KingFeb 16, 2015
  3. 0/2 clean up push config callbacksJeff King, Feb 16, 2015
  4. 1/2 git_push_config: drop cargo-culted wt_status pointerJeff King, Feb 16, 2015
  5. 2/2 builtin/push.c: make push_default a static variableJeff King, Feb 16, 2015
  6. Junio C HamanoFeb 16, 2015
  7. Jeff KingFeb 17, 2015
  8. Junio C HamanoFeb 17, 2015
  9. Jeff KingFeb 17, 2015
  10. Junio C HamanoFeb 17, 2015
  11. Jeff KingFeb 18, 2015
  12. Junio C HamanoFeb 18, 2015
  13. Jeff KingFeb 18, 2015
  14. Junio C HamanoFeb 18, 2015
  15. Jeff KingFeb 18, 2015
  16. 3/2 push: allow --follow-tags to be set by config push.followTagsJeff King, Feb 16, 2015
  17. Junio C HamanoFeb 16, 2015
  18. 0/3 cleaner bit-setting in cmd_pushJeff King, Feb 16, 2015
  19. 1/3 cmd_push: set "atomic" bit directlyJeff King, Feb 16, 2015
  20. 2/3 cmd_push: pass "flags" pointer to config callbackJeff King, Feb 16, 2015
  21. Junio C HamanoFeb 16, 2015
  22. Jeff KingFeb 16, 2015
  23. 3/3 push: allow --follow-tags to be set by config push.followTagsJeff King, Feb 16, 2015
  24. Junio C HamanoMar 14, 2015
  25. Jeff KingMar 14, 2015
  26. Dave OlszewskiMar 14, 2015
  27. Junio C HamanoMar 14, 2015
  28. Junio C HamanoFeb 16, 2015
  29. Jeff KingFeb 16, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.