[PATCH 1/2] git_push_config: drop cargo-culted wt_status pointer
- From
Jeff King <peff@peff.net>
- Date
- Feb 16, 2015, 05:46 UTC
- Message-ID
- <20150216054629.GA25088@peff.net>
- In-Reply-To
- <20150216054550.GA24611@peff.net>
The push config callback does not expect any incoming data via the void pointer. And if it did, it would certainly not be a "struct wt_status". This probably got picked up accidentally in b945901 (push: heed user.signingkey for signed pushes, 2014-10-22), which copied the template for the config callback from builtin/commit.c.
Signed-off-by: Jeff King <peff@peff.net> --- builtin/push.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/builtin/push.c b/builtin/push.c index fc771a9..aa9334c 100644 --- a/builtin/push.c +++ b/builtin/push.c @@ -473,13 +473,12 @@ static int option_parse_recurse_submodules(const struct option *opt, static int git_push_config(const char *k, const char *v, void *cb) { - struct wt_status *s = cb; int status; status = git_gpg_config(k, v, NULL); if (status) return status; - return git_default_config(k, v, s); + return git_default_config(k, v, NULL); } int cmd_push(int argc, const char **argv, const char *prefix)
-- 2.3.0.rc1.287.g761fd19