Re: [PATCH v2 3/3] http-backend: spool ref negotiation requests to buffer

From: Junio C Hamano <gitster@pobox.com>
Date: May 26, 2015, 03:43 UTC
Message-ID: <xmqqk2vw80mr.fsf@gitster.dls.corp.google.com>
In-Reply-To: <20150526022401.GA1725@peff.net>

Jeff King <peff@peff.net> writes:

Show 7 quoted lines

> Whoops, yeah, it was just for debugging. I missed that one when sending
> out the patch.
>
> Junio, the squashable patch is below (on jk/http-backend-deadlock-2.2),
> and it looks like nothing has hit "next" yet. But you did do some
> up-merging of the topic. Let me know if you would prefer to just have a
> patch on top.

Sorry, I missed that, too (actually I saw warning() and said "Heh, OK", without realizing that this is a normal return path).

Thanks.

Show 15 quoted lines

>
> diff --git a/http-backend.c b/http-backend.c
> index d1333b8..6bf139b 100644
> --- a/http-backend.c
> +++ b/http-backend.c
> @@ -295,7 +295,6 @@ static ssize_t read_request(int fd, unsigned char **out)
>  		len += cnt;
>  		if (len < alloc) {
>  			*out = buf;
> -			warning("request size was %lu", (unsigned long)len);
>  			return len;
>  		}
>  
>
> -Peff