git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] http-backend: fix die recursion with custom handler

From
Jeff King <peff@peff.net>
Date
May 15, 2015, 06:20 UTC
Message-ID
<20150515062034.GA30741@peff.net>
In-Reply-To
<20150514010233.GA7808@peff.net>
On Wed, May 13, 2015 at 09:02:33PM -0400, Jeff King wrote:
Show 5 quoted lines
> +static int die_webcgi_recursing(void)
> +{
> +	dead++;
> +	return dead > 1;
> +}

Ugh, somehow I managed to introduce an off-by-one here while prettifying the code before sending. It should be "> 2" (or "dead++ > 1" to get the value before incrementing).

The series I'll post in a moment will have a fixed version.
-Peff
Previous: Jeff KingNext: Konstantin Ryabitsev
Message 4 of 24 in “Clone hangs when done over http with --reference”
  1. Konstantin RyabitsevMay 13, 2015
  2. Jeff KingMay 14, 2015
  3. http-backend: fix die recursion with custom handlerJeff King, May 14, 2015
  4. Jeff KingMay 15, 2015
  5. Konstantin RyabitsevMay 14, 2015
  6. Jeff KingMay 14, 2015
  7. 0/2 fix http deadlock on giant ref negotiationsJeff King, May 15, 2015
  8. 1/2 http-backend: fix die recursion with custom handlerJeff King, May 15, 2015
  9. 2/2 http-backend: spool ref negotiation requests to bufferJeff King, May 15, 2015
  10. Junio C HamanoMay 15, 2015
  11. Konstantin RyabitsevMay 15, 2015
  12. 0/3 fix http deadlock on giant ref negotiationsJeff King, May 20, 2015
  13. 1/3 http-backend: fix die recursion with custom handlerJeff King, May 20, 2015
  14. 2/3 t5551: factor out tag creationJeff King, May 20, 2015
  15. 3/3 http-backend: spool ref negotiation requests to bufferJeff King, May 20, 2015
  16. Konstantin RyabitsevMay 26, 2015
  17. Jeff KingMay 26, 2015
  18. Junio C HamanoMay 26, 2015
  19. Jeff KingMay 15, 2015
  20. Dennis KaarsemakerMay 15, 2015
  21. Jeff KingMay 15, 2015
  22. Dennis KaarsemakerMay 15, 2015
  23. Jeff KingMay 15, 2015
  24. Dennis KaarsemakerMay 15, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.