Re: [PATCH v2 3/3] http-backend: spool ref negotiation requests to buffer

From: Konstantin Ryabitsev <konstantin@linuxfoundation.org>
Date: May 26, 2015, 02:07 UTC
Message-ID: <CAMwyc-Tn+Sw67z9zTPsPU7SQP7PDzJhoJn30utQ0OWhKe_xbuA@mail.gmail.com>
In-Reply-To: <20150520073709.GC9818@peff.net>

On 20 May 2015 at 03:37, Jeff King <peff@peff.net> wrote:

Show 7 quoted lines

> +               /* partial read from read_in_full means we hit EOF */
> +               len += cnt;
> +               if (len < alloc) {
> +                       *out = buf;
> +                       warning("request size was %lu", (unsigned long)len);
> +                       return len;
> +               }

Jeff:

This patch appears to work well -- the only complaint I have is that I now have "warning: request size was NNN" all over my error logs. :) Is it supposed to convey an actual warning message, or is it merely a debug statement?

Best,

-- 
Konstantin Ryabitsev
Sr. Systems Administrator
Linux Foundation Collab Projects
541-224-6067
Montréal, Québec