git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 7/7] Add a config option push.gpgSign for default signed pushes

From
Junio C Hamano <gitster@pobox.com>
Date
Aug 17, 2015, 19:42 UTC
Message-ID
<xmqqk2std7lt.fsf@gitster.dls.corp.google.com>
In-Reply-To
<CAD0k6qTnJPc+Nh6dck0_Zx9vnyn5YVMCmy3E=7vr8bTpRSppAA@mail.gmail.com>
Dave Borowitz <dborowitz@google.com> writes:
Show 7 quoted lines
> The issue is that if both _ALWAYS and _IF_POSSIBLE are set,
> git_transport_push interprets it as _ALWAYS. But, we are also supposed
> to prefer explicit command-line options to config values.
>
> Suppose we parsed config first, then options. If the user has
> push.signed = always and and passes --signed-if-possible, then the end
> result is (_ALWAYS | _IF_POSSIBLE), aka always,...

Doesn't that merely suggest that the option parsing is implemented incorrectly? Why is --signed-if-possible just ORing its bits into the flag, instead of clearing and setting?

Previous: Dave BorowitzNext: Junio C Hamano
Message 16 of 32 in “Flags and config to sign pushes by default”
  1. 0/7 Flags and config to sign pushes by defaultDave Borowitz, Aug 13, 2015
  2. 1/7 Documentation/git-push.txt: Document when --signed may failDave Borowitz, Aug 13, 2015
  3. Junio C HamanoAug 14, 2015
  4. Dave BorowitzAug 17, 2015
  5. 2/7 Documentation/git-send-pack.txt: Flow long synopsis lineDave Borowitz, Aug 13, 2015
  6. 3/7 Documentation/git-send-pack.txt: Document --signedDave Borowitz, Aug 13, 2015
  7. 4/7 gitremote-helpers.txt: Document pushcert optionDave Borowitz, Aug 13, 2015
  8. 5/7 transport: Remove git_transport_options.push_certDave Borowitz, Aug 13, 2015
  9. Junio C HamanoAug 14, 2015
  10. 6/7 Support signing pushes iff the server supports itDave Borowitz, Aug 13, 2015
  11. Junio C HamanoAug 14, 2015
  12. Dave BorowitzAug 19, 2015
  13. 7/7 Add a config option push.gpgSign for default signed pushesDave Borowitz, Aug 13, 2015
  14. Junio C HamanoAug 17, 2015
  15. Dave BorowitzAug 17, 2015
  16. Junio C HamanoAug 17, 2015
  17. Junio C HamanoAug 17, 2015
  18. Dave BorowitzAug 17, 2015
  19. Chris PackhamAug 14, 2015
  20. Junio C HamanoAug 14, 2015
  21. Dave BorowitzAug 14, 2015
  22. Dave BorowitzAug 14, 2015
  23. Junio C HamanoAug 14, 2015
  24. Dave BorowitzAug 14, 2015
  25. Junio C HamanoAug 14, 2015
  26. Junio C HamanoAug 17, 2015
  27. Dave BorowitzAug 17, 2015
  28. Junio C HamanoAug 17, 2015
  29. Dave BorowitzAug 17, 2015
  30. Junio C HamanoAug 17, 2015
  31. Dave BorowitzAug 17, 2015
  32. Junio C HamanoAug 17, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.