Re: [PATCH 0/7] Flags and config to sign pushes by default
- From
Dave Borowitz <dborowitz@google.com>
- Date
- Aug 17, 2015, 20:00 UTC
- Message-ID
- <CAD0k6qS9qA2vrrxF6SQJ-RsX01rryCuZ0zPn4k+OP__TOPR2gg@mail.gmail.com>
- In-Reply-To
- <xmqq7fotd71o.fsf@gitster.dls.corp.google.com>
On Mon, Aug 17, 2015 at 3:54 PM, Junio C Hamano <gitster@pobox.com> wrote:
Show 6 quoted lines
> In the shorter term, at least we should be able to introduce > git_parse_maybe_bool() that does not take "name", use that as a > helper to implement git_config_maybe_bool(), so that the existing > callers of git_config_maybe_bool() does not have to change. And > that new helper can be used as your "Basically it, but not > specifically about configs".
Will do, thanks for the suggestion.
Slight digression for a question that came up during reworking the series: would it be reasonable to rewrite option parsing in builtin/send-pack.c to use the options API? That way we can easily reuse the option callback from builtin/push.c. (It would have some side effects like making --no-* variants work where they did not before; I assume that's a good thing, but it's marginally inconsistent with some other plumbing commands like receive-pack.)