git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 0/7] Flags and config to sign pushes by default

From
Dave Borowitz <dborowitz@google.com>
Date
Aug 14, 2015, 20:55 UTC
Message-ID
<CAD0k6qR2HkHHYu8429mvdvN1bkLeTpD-5EbO4Mt+o69rC+P6aQ@mail.gmail.com>
In-Reply-To
<xmqqwpwxha4r.fsf@gitster.dls.corp.google.com>
On Fri, Aug 14, 2015 at 4:45 PM, Junio C Hamano <gitster@pobox.com> wrote:
Show 13 quoted lines
> Dave Borowitz <dborowitz@google.com> writes:
>
>> On Fri, Aug 14, 2015 at 2:12 PM, Junio C Hamano <gitster@pobox.com> wrote:
>>> Yes, it looks somewhat strange.
>> ... The straw-man
>> strangeness is that two of them are the traditional boolean values
>> "true/false" and the third is "file not found^W^W^Wif-possible" :)
>
> It actually is not uncommon for a Git configuration variable to
> start its life as a boolean and then later become tristate (or more)
> as we gain experience with the system, so don't worry about it being
> "strange".  A tristate, among whose choices two of them are true and
> false, is not "strange" around here.
Ok, so let us bikeshed a bit further.

Bikeshed 1. Option A: --signed/--no-signed--signed-if-possible Option B: --signed=true|false|if-possible, "--signed" alone implies "=true".

Bikeshed 2.
Option A: if-possible

The possibly confusing thing is one might interpret missing "gpg" to mean "impossible", i.e. "if gpg is not installed don't attempt to sign", which is not the behavior we want.

I don't have another succinct way of saying this. "if-server-supported" is a mouthful. I think Jonathan mentioned "opportunistic", which is fairly opaque.

Show 5 quoted lines
> By "strange", I was referring to the possible perception issue on
> having a choice other than yes/no for a configuration that allows
> you to express your security preference.
>
> Thanks.
Previous: Junio C HamanoNext: Junio C Hamano
Message 24 of 32 in “Flags and config to sign pushes by default”
  1. 0/7 Flags and config to sign pushes by defaultDave Borowitz, Aug 13, 2015
  2. 1/7 Documentation/git-push.txt: Document when --signed may failDave Borowitz, Aug 13, 2015
  3. Junio C HamanoAug 14, 2015
  4. Dave BorowitzAug 17, 2015
  5. 2/7 Documentation/git-send-pack.txt: Flow long synopsis lineDave Borowitz, Aug 13, 2015
  6. 3/7 Documentation/git-send-pack.txt: Document --signedDave Borowitz, Aug 13, 2015
  7. 4/7 gitremote-helpers.txt: Document pushcert optionDave Borowitz, Aug 13, 2015
  8. 5/7 transport: Remove git_transport_options.push_certDave Borowitz, Aug 13, 2015
  9. Junio C HamanoAug 14, 2015
  10. 6/7 Support signing pushes iff the server supports itDave Borowitz, Aug 13, 2015
  11. Junio C HamanoAug 14, 2015
  12. Dave BorowitzAug 19, 2015
  13. 7/7 Add a config option push.gpgSign for default signed pushesDave Borowitz, Aug 13, 2015
  14. Junio C HamanoAug 17, 2015
  15. Dave BorowitzAug 17, 2015
  16. Junio C HamanoAug 17, 2015
  17. Junio C HamanoAug 17, 2015
  18. Dave BorowitzAug 17, 2015
  19. Chris PackhamAug 14, 2015
  20. Junio C HamanoAug 14, 2015
  21. Dave BorowitzAug 14, 2015
  22. Dave BorowitzAug 14, 2015
  23. Junio C HamanoAug 14, 2015
  24. Dave BorowitzAug 14, 2015
  25. Junio C HamanoAug 14, 2015
  26. Junio C HamanoAug 17, 2015
  27. Dave BorowitzAug 17, 2015
  28. Junio C HamanoAug 17, 2015
  29. Dave BorowitzAug 17, 2015
  30. Junio C HamanoAug 17, 2015
  31. Dave BorowitzAug 17, 2015
  32. Junio C HamanoAug 17, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.