Re: [PATCH v2 3/3] git: simplify environment save/restore logic

From: Junio C Hamano <gitster@pobox.com>
Date: Jan 27, 2016, 23:47 UTC
Message-ID: <xmqqk2mu60vl.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <xmqqoac6621o.fsf_-_@gitster.mtv.corp.google.com>

Junio C Hamano <gitster@pobox.com> writes:

Show 11 quoted lines

> @@ -598,9 +597,9 @@ static int run_argv(int *argcp, const char ***argv)
>  		 */
>  		if (done_alias)
>  			break;
> +		done_alias = 1;
>  		if (!handle_alias(argcp, argv))
>  			break;
> -		done_alias = 1;
>  	}
>  
>  	return done_alias;

This hunk shouldn't be there; it changes the return value from this function and breaks the whole thing.

What I will push out as part of 'pu' will have this fixed.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.