git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] git.c: fix help.autocorrect after 57ea712 breaks it

From
Duy Nguyen <pclouds@gmail.com>
Date
Jan 27, 2016, 09:14 UTC
Message-ID
<CACsJy8DzHYpw3TT3i17W-8eiR9J9DOQUO6mkxffUEnGqT1u96Q@mail.gmail.com>
In-Reply-To
<xmqqbn87a54v.fsf@gitster.mtv.corp.google.com>
On Wed, Jan 27, 2016 at 1:49 PM, Junio C Hamano <gitster@pobox.com> wrote:
Show 9 quoted lines
> Junio C Hamano <gitster@pobox.com> writes:
>
>> I spoke too soon, I am afraid.
>> ...
>> I wonder if this would be better done as a multi-part series that
>> goes like this:
>> ...
>
> So here is the first of the three-patch series to replace it.

This is much better (the whole series, not just the first patch). We probably should add a test about help.autocorrect though, maybe in the first patch, because it's not tested at all in the test suite.

-- 
Duy
Previous: Junio C HamanoNext: Junio C Hamano
Message 14 of 22 in “[BUG] typo DWIMery with alias broken (cd to random dir)”
  1. Michael J GruberJan 26, 2016
  2. Duy NguyenJan 26, 2016
  3. git.c: fix help.autocorrect after 57ea712 breaks itNguyễn Thái Ngọc Duy, Jan 26, 2016
  4. Michael J GruberJan 26, 2016
  5. Junio C HamanoJan 26, 2016
  6. Junio C HamanoJan 26, 2016
  7. Junio C HamanoJan 26, 2016
  8. Junio C HamanoJan 27, 2016
  9. 2/3 git: protect against unbalanced calls to {save,restore}_env()Junio C Hamano, Jan 27, 2016
  10. 2/3 git: protect against unbalanced calls to {save,restore}_env()Junio C Hamano, Jan 27, 2016
  11. 3/3 git: simplify environment save/restore logicJunio C Hamano, Jan 27, 2016
  12. 3/3 git: simplify environment save/restore logicJunio C Hamano, Jan 27, 2016
  13. Junio C HamanoJan 27, 2016
  14. Duy NguyenJan 27, 2016
  15. Junio C HamanoJan 27, 2016
  16. 1/3 git: remove an early return from save_env_before_alias()Junio C Hamano, Jan 27, 2016
  17. 1/4 git: remove an early return from save_env_before_alias()Junio C Hamano, Feb 2, 2016
  18. 2/4 git: protect against unbalanced calls to {save,restore}_env()Junio C Hamano, Feb 2, 2016
  19. 3/4 git: simplify environment save/restore logicJunio C Hamano, Feb 2, 2016
  20. 4/4 restore_env(): free the saved environment variable once we are doneJunio C Hamano, Feb 2, 2016
  21. Eric SunshineFeb 3, 2016
  22. Junio C HamanoFeb 3, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.