Re: [PATCH v2 10/14] sequencer: lib'ify read_populate_opts()
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Aug 30, 2016, 17:21 UTC
- Message-ID
- <xmqqk2ey5g0m.fsf@gitster.mtv.corp.google.com>
- In-Reply-To
- <alpine.DEB.2.20.1608301116450.129229@virtualbox>
Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
> I still think that it is a serious mistake for library functions to die(). > But I have no time to take care of git_parse_source() right now.
I think we already agreed on both points during the previous round of review ;-)