Re: [PATCH 06/15] sequencer: lib'ify read_populate_todo()
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- Aug 24, 2016, 15:57 UTC
- Message-ID
- <alpine.DEB.2.20.1608241754590.4924@virtualbox>
- In-Reply-To
- <CAPig+cSR8BHFdMJz5mFkpJ3UU6w0Xmjav+tu6f3DrkG4Gi-v6A@mail.gmail.com>
Hi Eric,
On Wed, 24 Aug 2016, Eric Sunshine wrote:
Show 17 quoted lines
> On Tue, Aug 23, 2016 at 12:07 PM, Johannes Schindelin
> <johannes.schindelin@gmx.de> wrote:
> > To be truly useful, the sequencer should never die() but always return
> > an error.
> >
> > Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
> > ---
> > diff --git a/sequencer.c b/sequencer.c
> > @@ -754,18 +754,21 @@ static void read_populate_todo(struct commit_list **todo_list,
> >
> > fd = open(git_path_todo_file(), O_RDONLY);
> > if (fd < 0)
> > - die_errno(_("Could not open %s"), git_path_todo_file());
> > + return error(_("Could not open %s (%s)"),
> > + git_path_todo_file(), strerror(errno));
>
> error_errno() perhaps?Absolutely!
Thanks, Dscho