Re: [PATCH v2 12/14] sequencer: lib'ify save_head()
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- Aug 30, 2016, 09:21 UTC
- Message-ID
- <alpine.DEB.2.20.1608301120510.129229@virtualbox>
- In-Reply-To
- <xmqqy43f8fnc.fsf@gitster.mtv.corp.google.com>
Hi Junio,
On Mon, 29 Aug 2016, Junio C Hamano wrote:
Show 10 quoted lines
> Johannes Schindelin <johannes.schindelin@gmx.de> writes:
>
> > strbuf_addf(&buf, "%s\n", head);
> > if (write_in_full(fd, buf.buf, buf.len) < 0)
> > - die_errno(_("Could not write to %s"), git_path_head_file());
> > + return error_errno(_("Could not write to %s"),
> > + git_path_head_file());
>
> Same comment around a left-over lockfile applies to this. An extra
> rollback being minimally intrusive also applies here, I think.Sure. I added rollbacks in case of failure.
Ciao, Dscho