Re: [PATCH v1 00/19] Add configuration options for split-index

From: Junio C Hamano <gitster@pobox.com>
Date: Oct 25, 2016, 17:21 UTC
Message-ID: <xmqqk2cws5t6.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <CACsJy8BBwWRGSyJDYQ7THj7quu4=T1xT_-KojQd45Vye4Kgcng@mail.gmail.com>

Duy Nguyen <pclouds@gmail.com> writes:

> ... But those files
> people generate manually and refer to them with $GIT_INDEX_FILE, we
> can't know where they are.

Then we probably should stop doing that, i.e. disable split-index automatically for these temporary ones, perhaps, and even with Christian's series which allows use of split index on the primary one easier (which is a good idea), make sure we don't auto split the temporary ones the users create?

Show 5 quoted lines

> Timestamps allow us to say, ok this base index file has not been read
> by anybody for N+ hours (or better, days), it's most likely not
> referenced by any temporary index files (including
> $GIT_DIR/index.lock) anymore because those files, by the definition of
> "temporary", must be gone by now....

and if we guessed wrong, users will have a "temporary index" that they meant to keep for longer term that is now broken here. I am not sure if that risk is worth taking.