Re: [PATCH v1 09/19] config: add git_config_get_max_percent_split_change()

From: Duy Nguyen <pclouds@gmail.com>
Date: Oct 25, 2016, 10:06 UTC
Message-ID: <CACsJy8A0djR6=s0AY0tzVehYY5b1-o11uRsFdGtOUCeu4Z6Xjw@mail.gmail.com>
In-Reply-To: <20161023092648.12086-10-chriscool@tuxfamily.org>

On Sun, Oct 23, 2016 at 4:26 PM, Christian Couder <christian.couder@gmail.com> wrote:

Show 10 quoted lines

> This new function will be used in a following commit to get the
> +int git_config_get_max_percent_split_change(void)
> +{
> +       int val = -1;
> +
> +       if (!git_config_get_int("splitindex.maxpercentchange", &val)) {
> +               if (0 <= val && val <= 100)
> +                       return val;
> +
> +               error("splitindex.maxpercentchange value '%d' "

We should keep camelCase form for easy reading. And wrap this string with _().

> +                     "should be between 0 and 100", val);

I wonder if anybody would try to put 12.3 here and confused by the error message, because 0 <= 12.3 <= 100, but it's not an integer.. Ah.. never mind, die_bad_number() would be called first in this case with a loud and clear complaint.

> +               return -1;
> +       }
> +
> +       return -1; /* default value */

-- 
Duy