Re: [PATCH v1 05/19] update-index: warn in case of split-index incoherency

From: Junio C Hamano <gitster@pobox.com>
Date: Nov 2, 2016, 01:37 UTC
Message-ID: <xmqqins6mzku.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <CAP8UFD18gcMJY7zjXw+ry6Kq2Foug9r0e=OVgZ_hcFkEVfnChA@mail.gmail.com>

Christian Couder <christian.couder@gmail.com> writes:

Show 13 quoted lines

>>> Wrap this string and the one below with _() so they can be translated.
>>
>> True.
>>
>> I further wonder if a natural reaction from users after seeing this
>> message is "I do want to--what else would I use that option to run
>> you for?  Just do as you are told, instead of telling me what to
>> do!".  Is this warning really a good idea, or shouldn't these places
>> be setting the configuration?
>
> In 435ec090ec (config: add core.untrackedCache, 2016-01-27) we decided
> to just use warning() after discussing if we should instead set the
> configuration.

Yeah that seems to be the version that was committed. I then wonder if the users would naturally have a similar raction to that warning as well.