Re: [PATCH] builtin/send-pack: populate the default configs

From: Junio C Hamano <gitster@pobox.com>
Date: Jun 12, 2018, 17:38 UTC
Message-ID: <xmqqk1r3aorh.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <20180612172623.165420-1-masayasuzuki@google.com>

Masaya Suzuki <masayasuzuki@google.com> writes:

Show 8 quoted lines

> builtin/send-pack didn't call git_default_config, and because of this
> git push --signed didn't respect the username and email in gitconfig in
> the HTTP transport.
>
> Signed-off-by: Masaya Suzuki <masayasuzuki@google.com>
> ---
>  builtin/send-pack.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Makes sense. I wonder if this was deliberate (i.e. we had some reason not wanting to be affected by some _other_ configuration items and refraining from doing the default-config was the way to implement it), but I do not think of a reason offhand.

Will queue.  Thanks.

Show 14 quoted lines

>
> diff --git a/builtin/send-pack.c b/builtin/send-pack.c
> index 4923b1058..42fd8d1a3 100644
> --- a/builtin/send-pack.c
> +++ b/builtin/send-pack.c
> @@ -121,7 +121,7 @@ static int send_pack_config(const char *k, const char *v, void *cb)
>  			}
>  		}
>  	}
> -	return 0;
> +	return git_default_config(k, v, cb);
>  }
>  
>  int cmd_send_pack(int argc, const char **argv, const char *prefix)