git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] builtin/send-pack: populate the default configs

From
Masaya Suzuki <masayasuzuki@google.com>
Date
Jun 12, 2018, 17:26 UTC
Message-ID
<20180612172623.165420-1-masayasuzuki@google.com>

builtin/send-pack didn't call git_default_config, and because of this git push --signed didn't respect the username and email in gitconfig in the HTTP transport.

Signed-off-by: Masaya Suzuki <masayasuzuki@google.com>
---
 builtin/send-pack.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/builtin/send-pack.c b/builtin/send-pack.c
index 4923b1058..42fd8d1a3 100644
--- a/builtin/send-pack.c
+++ b/builtin/send-pack.c
@@ -121,7 +121,7 @@ static int send_pack_config(const char *k, const char *v, void *cb)
 			}
 		}
 	}
-	return 0;
+	return git_default_config(k, v, cb);
 }
 
 int cmd_send_pack(int argc, const char **argv, const char *prefix)
-- 
2.18.0.rc1.242.g61856ae69a-goog
Next: Junio C Hamano
Message 1 of 8 in “builtin/send-pack: populate the default configs”
  1. builtin/send-pack: populate the default configsMasaya Suzuki, Jun 12, 2018
  2. Junio C HamanoJun 12, 2018
  3. builtin/send-pack: report gpg config errorsStefan Beller, Jun 12, 2018
  4. Eric SunshineJun 12, 2018
  5. Jonathan NiederJun 12, 2018
  6. Stefan BellerJun 12, 2018
  7. Jonathan NiederJun 12, 2018
  8. Eric SunshineJun 12, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.