Re: [PATCH] builtin/send-pack: report gpg config errors

From: Jonathan Nieder <jrnieder@gmail.com>
Date: Jun 12, 2018, 18:07 UTC
Message-ID: <20180612180705.GA28554@aiede.svl.corp.google.com>
In-Reply-To: <20180612175344.65466-1-sbeller@google.com>

Hi,

Stefan Beller wrote:

Show 8 quoted lines

> Any caller except of git_gpg_config() except the one in send_pack_config()
> handles the return value of git_gpg_config(). Also handle the return value
> there.
>
> Signed-off-by: Stefan Beller <sbeller@google.com>
> ---
>  builtin/send-pack.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)

The other callers do

	int status;

	if (!strcmp(k, "key.i.handle")) {
		...
		return ...;
	}
	return git_gpg_config(k, v, NULL);

or

	int status;

	if (!strcmp(k, "key.i.handle")) {
		...
		return ...;
	}

	status = git_gpg_config(k, v, NULL);
	if (status)
		return status;
	...

Should this do the same? That way, if config_fn_t learns to return more fine-grained errors (e.g. a new return value of -2 or 1) then it would be propagated.

Thanks, Jonathan