Re: [PATCH] Add an EditorConfig file

From: Junio C Hamano <gitster@pobox.com>
Date: Sep 20, 2018, 14:08 UTC
Message-ID: <xmqqk1ng2rdo.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <20180920000013.GZ432229@genre.crustytoothpaste.net>

"brian m. carlson" <sandals@crustytoothpaste.net> writes:

Show 6 quoted lines

> I think "make style" and the EditorConfig file are complementary.  "make
> style" autoformats code into a diff.  I agree that if we always used
> clang-format to format code, then this would be a non-issue in the
> EditorConfig file, since we'd just tell people to format their code and
> be done with it.  However, we don't automatically do that, so I think
> this still has value.

Oh, we agree on that 100%.  These are complementary.

My comment was that it would be confusing if they gave contradicting suggestions to the end user. After letting EditorConfig to enforce one style while typing and saving, if "make style" suggests to format it differently, it would not be a great user experience.

The ideal response would have been "Oh, of course EditorConfig folks already thought about that, which is a natural thing to wish for, and they have a tool to generate clang-format configuration from the section for C language in any EditorConfig file---here is a link. After all, tools like clang-format look like just another editor to them ;-)".

But that is a response in a dream-world. If there is no such tool, I am perfectly OK if the plan is to manually keep them (loosely) in sync. I do not think it is good use of our time to try to come up with such a tool (unless somebody is really interested in doing it, that is).

Thanks.