Re: [PATCH] Add an EditorConfig file

From: brian m. carlson <sandals@crustytoothpaste.net>
Date: Sep 21, 2018, 22:19 UTC
Message-ID: <20180921221918.GB432229@genre.crustytoothpaste.net>
In-Reply-To: <20180921023503.GA29606@sigill.intra.peff.net>

On Thu, Sep 20, 2018 at 10:35:04PM -0400, Jeff King wrote:

Show 10 quoted lines

> On Thu, Sep 20, 2018 at 10:26:47PM -0400, Eric Sunshine wrote:
> 
> > On Wed, Sep 19, 2018 at 8:00 PM brian m. carlson
> > <sandals@crustytoothpaste.net> wrote:
> > > (I am having trouble getting make style to work, though, because it
> > > seems to invoke clang-format as a git subcommand, and I don't think that
> > > works.  I may send a patch.)
> > 
> > You're probably missing this piece:
> > https://llvm.org/svn/llvm-project/cfe/trunk/tools/clang-format/git-clang-format

I am indeed missing that. I looked for it in git.git, but didn't think to look for it as part of clang-format.

> I've been confused by this, too. In Debian they ship it with the version
> number. E.g., /usr/bin/git-clang-format-7, which is a symlink to
> /usr/lib/llvm-7/bin/git-clang-format.

I filed a bug report asking Debian to include a symlink in the default package.

> We might want a Makefile variable to let you override this path (I think
> I just ended up putting another symlink in ~/local/bin).

I may send a patch to do that.

-- 
brian m. carlson: Houston, Texas, US
OpenPGP: https://keybase.io/bk2204