Re: [PATCH] Add an EditorConfig file

From: Jeff King <peff@peff.net>
Date: Sep 21, 2018, 02:35 UTC
Message-ID: <20180921023503.GA29606@sigill.intra.peff.net>
In-Reply-To: <CAPig+cTQuwMDMpHe4inO61=Mq2+q1OdGsEG_hpii+dNmjXHZLg@mail.gmail.com>

On Thu, Sep 20, 2018 at 10:26:47PM -0400, Eric Sunshine wrote:

Show 8 quoted lines

> On Wed, Sep 19, 2018 at 8:00 PM brian m. carlson
> <sandals@crustytoothpaste.net> wrote:
> > (I am having trouble getting make style to work, though, because it
> > seems to invoke clang-format as a git subcommand, and I don't think that
> > works.  I may send a patch.)
> 
> You're probably missing this piece:
> https://llvm.org/svn/llvm-project/cfe/trunk/tools/clang-format/git-clang-format

I've been confused by this, too. In Debian they ship it with the version number. E.g., /usr/bin/git-clang-format-7, which is a symlink to /usr/lib/llvm-7/bin/git-clang-format.

We might want a Makefile variable to let you override this path (I think I just ended up putting another symlink in ~/local/bin).

-Peff