git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] msvc: Directly use MS version (_stricmp) of strcasecmp

From
Junio C Hamano <gitster@pobox.com>
Date
Nov 19, 2018, 02:02 UTC
Message-ID
<xmqqk1l9esey.fsf@gitster-ct.c.googlers.com>
In-Reply-To
<20181118215820.GA14514@sigill.intra.peff.net>
Jeff King <peff@peff.net> writes:
Show 6 quoted lines
> And it seems we worked around this in de2f95ebed (mailmap: work around
> implementations with pure inline strcasecmp, 2013-09-12). So I don't
> think there is any blocker there.
>
> (Though of course I have no idea on other portability questions around
> _stricmp(); I'll leave that for Windows folks).

Likewise. As to the placement for the replacement #define, the patch puts it where the inline version was, but I would think it would work better if it were in the block of #defines, immediately next to #define strncasecmp above. .

Previous: Jeff KingNext: Sven Strickroth
Message 3 of 6 in “msvc: Directly use MS version (_stricmp) of strcasecmp”
  1. msvc: Directly use MS version (_stricmp) of strcasecmpSven Strickroth, Nov 18, 2018
  2. Jeff KingNov 18, 2018
  3. Junio C HamanoNov 19, 2018
  4. msvc: Directly use MS version (_stricmp) of strcasecmpSven Strickroth, Nov 19, 2018
  5. Junio C HamanoNov 20, 2018
  6. Johannes SchindelinNov 20, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.