From: Junio C Hamano <gitster@pobox.com>
Date: Mon, 19 Nov 2018 02:02:13 GMT
Subject: Re: [PATCH] msvc: Directly use MS version (_stricmp) of strcasecmp
Message-ID: <xmqqk1l9esey.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <20181118215820.GA14514@sigill.intra.peff.net>

Jeff King <peff@peff.net> writes:

> And it seems we worked around this in de2f95ebed (mailmap: work around
> implementations with pure inline strcasecmp, 2013-09-12). So I don't
> think there is any blocker there.
>
> (Though of course I have no idea on other portability questions around
> _stricmp(); I'll leave that for Windows folks).

Likewise.  As to the placement for the replacement #define, the
patch puts it where the inline version was, but I would think it
would work better if it were in the block of #defines, immediately
next to #define strncasecmp above.
.