git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] msvc: Directly use MS version (_stricmp) of strcasecmp

From
Sven Strickroth <email@cs-ware.de>
Date
Nov 19, 2018, 15:14 UTC
Message-ID
<15a7df69-25d8-c168-dd43-a43b7f0d34c1@cs-ware.de>
In-Reply-To
<xmqqk1l9esey.fsf@gitster-ct.c.googlers.com>
This also removes an implicit conversion from size_t (unsigned) to int (signed).
_stricmp as well as _strnicmp are both available since VS2012.
Signed-off-by: Sven Strickroth <email@cs-ware.de>
---
 compat/msvc.h | 8 +-------
 1 file changed, 1 insertion(+), 7 deletions(-)
diff --git a/compat/msvc.h b/compat/msvc.h
index e6e1a6bbf7..2d558bae14 100644
--- a/compat/msvc.h
+++ b/compat/msvc.h
@@ -14,18 +14,12 @@
 #define inline __inline
 #define __inline__ __inline
 #define __attribute__(x)
+#define strcasecmp   _stricmp
 #define strncasecmp  _strnicmp
 #define ftruncate    _chsize
 #define strtoull     _strtoui64
 #define strtoll      _strtoi64
 
-static __inline int strcasecmp (const char *s1, const char *s2)
-{
-	int size1 = strlen(s1);
-	int sisz2 = strlen(s2);
-	return _strnicmp(s1, s2, sisz2 > size1 ? sisz2 : size1);
-}
-
 #undef ERROR
 
 #define ftello _ftelli64
-- 
2.19.1.windows.1
Previous: Junio C HamanoNext: Junio C Hamano
Message 4 of 6 in “msvc: Directly use MS version (_stricmp) of strcasecmp”
  1. msvc: Directly use MS version (_stricmp) of strcasecmpSven Strickroth, Nov 18, 2018
  2. Jeff KingNov 18, 2018
  3. Junio C HamanoNov 19, 2018
  4. msvc: Directly use MS version (_stricmp) of strcasecmpSven Strickroth, Nov 19, 2018
  5. Junio C HamanoNov 20, 2018
  6. Johannes SchindelinNov 20, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.