Re: [GSoC][PATCH 1/3] sequencer: add advice for revert
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jun 10, 2019, 16:34 UTC
- Message-ID
- <xmqqk1dto0vo.fsf@gitster-ct.c.googlers.com>
- In-Reply-To
- <d59c078c-61da-1c3a-d215-80c9e3d08896@gmail.com>
Phillip Wood <phillip.wood123@gmail.com> writes:
Show 13 quoted lines
>> Firstly, signature of `create_seq_dir` doesn't allow us to call >> `sequencer_get_last_command()`. Changing that for the sake of a >> better error message is too much task for this patch as it is a >> subject of discussion on its own. > > There is only one caller and it already has a struct repository pointer > so it is a two line change, one of which is the insertion of a single > character to change create_seq_dir() so it can call > sequencer_get_last_command(). It is normal to change function signatures > (especially for static functions like this) when making changes, it is > part of improving the code base. The quality of error messages is > important to the overall user experience. It's when things go wrong that > users need accurate advice about what to do.
Thanks for guiding a new contributor in the right direction gently. Very much appreciated.