Re: [GSoC][PATCH 0/3] Teach cherry-pick/revert to skip commits

From: Rohit Ashiwal <rohit.ashiwal265@gmail.com>
Date: Jun 9, 2019, 10:06 UTC
Message-ID: <CAL7ArXpMBXwOGXWmYx8Rv9bj2trJ-FS_VGgPmJbAh+evbaxNEw@mail.gmail.com>
In-Reply-To: <20190609090235.GC28007@hank.intra.tgummerer.com>

Hey Thomas

On Sun, Jun 9, 2019 at 2:32 PM Thomas Gummerer <t.gummerer@gmail.com> wrote:

>
> Thanks!  I found a few minor nits that I missed in my off-list review
> on the PR.  We should give others some time to comment now before you
> re-send it with the nits fixed (if you agree with them).

Yes, I'll wait for some more reviews before sending another iteration.

> One thing that would be good to add to future cover letters is a
> reminder of how this fits in to your GSoC project, where the overall
> end goal is to improve the consistency of sequencer commands, and this
> is one step along that way.

Sure, I'll keep this in mind and send some kind of summary in the next revision.

Show 10 quoted lines

>
> > PR: https://github.com/r1walz/git/pull/1
> > Reviewed-by: Elijah Newren <newren@gmail.com>
> > Reviewed-by: Thomas Gummerer <t.gummerer@gmail.com>
>
> Note that the 'Reviewed-by' footer is something that is "given" by the
> reviewers, and should only be added after they have explicitly given
> it for the patch/series in question.  Instead this should probably
> mention that Elijah and me reviewed this off-list in the PR you linked
> to above.

Oh! But I read here, SubmittingPatches[1] docs, that it's nice to give credits to those who helped you. Should we fix it in some way? I don't know. Anyway, that is beyond the scope of this patch.

>
> > --
> > 2.21.0
> >

Thanks for the review Rohit

[1]: https://github.com/git/git/blob/v2.22.0/Documentation/SubmittingPatches#L289-L291