Re: [GSoC][PATCH v3 2/3] cherry-pick/revert: add --skip option

From: Junio C Hamano <gitster@pobox.com>
Date: Jun 14, 2019, 15:58 UTC
Message-ID: <xmqqd0jgupkj.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <20190614034554.19364-1-rohit.ashiwal265@gmail.com>

Rohit Ashiwal <rohit.ashiwal265@gmail.com> writes:

Show 9 quoted lines

>> Is this correct, or do we need to enclose these choices inside (),
>> i.e.
>> 
>> 	'git cherry-pick' ( --continue | --skip | --abort | --quit )
>> 
>> ?
>
> Documentation of `git rebase` also lists these options without the
> '('s so, I thought to make it similar to that.

As long as you picked the ones that correctly spell their SYNOPSIS, it is OK to model yours after them.

Seeing how "git-am.txt", "git-cat-file.txt", "git-checkout.txt", ... "git-var.txt" etc. all use

	( choice1 | choice2 | choice3 )

when one among the choices MUST be chosen, contrasting with

	[ choice1 | choice2 | choice3 ]

when one can be chosen but not using any is also OK, I am not sure if the documentation for "git rebase" is done right and should be used as a model, though.