Re: [PATCH 00/14] completion: a bunch of updates

From: Junio C Hamano <gitster@pobox.com>
Date: Jul 3, 2019, 17:50 UTC
Message-ID: <xmqqk1cz0zz1.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <20190621223107.8022-1-felipe.contreras@gmail.com>

Felipe Contreras <felipe.contreras@gmail.com> writes:

Show 24 quoted lines

> Here's another try at completion fixes, cleanups, and more tests. Some
> of these have already been sent.
>
> Felipe Contreras (14):
>   completion: zsh: fix __gitcomp_direct()
>   completion: zsh: fix for directories with spaces
>   completion: remove zsh hack
>   completion: zsh: improve main function selection
>   completion: prompt: fix color for Zsh
>   completion: bash: cleanup cygwin check
>   completion: zsh: update installation instructions
>   completion: bash: remove old compat wrappers
>   completion: bash: remove zsh wrapper
>   completion: zsh: trivial cleanups
>   test: completion: tests for __gitcomp regression
>   test: completion: use global config
>   completion: add default options
>   completion: add default merge strategies
>
>  contrib/completion/git-completion.bash | 202 +++++++++++++------------
>  contrib/completion/git-completion.zsh  |  53 +++----
>  contrib/completion/git-prompt.sh       |  10 +-
>  t/t9902-completion.sh                  |  37 +++--
>  4 files changed, 161 insertions(+), 141 deletions(-)

Having scanned the discussion threads so far, I think the last four patches are going against the list consensus of (1) it is OK to rely on --git-completion-helper; using ancient Git with new completion script won't obviously work, but that is "if it hurts, don't". (2) some subcommands will fail the --git-completion-helper request (e.g. outside a repository), but as long as the output from failed request is not cached, it is OK.

But we haven't seen any response to the earlier zsh specific patches. Does it mean that nobody other than Felipe cares about having a working Git completion for zsh? Or does it mean that all users other than Felipe are happy with the current Git completion for zsh and it works very well for them already? Or somewhere in between?

What I am trying to get at is if we would want to keep the earlier zsh parts of the series, but with nobody seemingly interested in, it is hard for me to justify queuing them.

Thanks.