Re: [PATCH 00/14] completion: a bunch of updates

From: Aaron Schrab <aaron@schrab.com>
Date: Nov 2, 2020, 23:05 UTC
Message-ID: <X6CQpfuhRkAwmMou@pug.qqx.org>
In-Reply-To: <CAMP44s3Tx1DdzD3fAOA+_3fLMK6Ew9GQAJWiRoA2KR156jiZBg@mail.gmail.com>

At 14:29 -0600 02 Nov 2020, Felipe Contreras <felipe.contreras@gmail.com> wrote:

Show 10 quoted lines

>So the two options are:
>
>1. Use the script in contrib/ (or git-completion)
>2. Use Oh-My-Zsh and enable the "gitfast" plugin
>
>In my opinion to use the Zsh default completion is not an option.
>
>Which is why I think distributions should package the Git Zsh
>completion by default (like Hombrew does), which will happen more
>easily if Git graduated those scripts and installed them by default.

The option that you consider to be invalid is definitely *my* preferred option. That Homebrew's git package installs the completion in a way that overrides that from the zsh package was a source of continual annoyance for me until I put in a long-term workaround for that (I had just been removing the symlink every time I noticed that it had been created by a new install of the git package).

While the completion provided by git.git may be faster, the one from zsh is fast enough on the repositories that I generally work with. At least with my configuration and the completion code currently shipped by Homobrew's git package there are at least a couple of things that seem to be quite broken.

The one that generally caused me to notice that the wrong completion code was being used is that it doesn't provide completion for creating local branches to based off of remote ones; I'd previously thought that was just a missing feature, but looking into it a bit more now it looks like that **should** happen as long as I don't set GIT_COMPLETION_CHECKOUT_NO_GUESS=1.

The other thing that seems to not work with the completion from git.git is completion of single-dash options. Although that may be more of a missing feature rather than something that's broken. Since there isn't any description for long options, I'd guess there wouldn't be for short options either; in which case there isn't really any point to trying to offer completion for those. But, having additional descriptions for options is one of my favorite features of zsh completion.