Re: [PATCH 00/14] completion: a bunch of updates

From: Junio C Hamano <gitster@pobox.com>
Date: Nov 3, 2020, 01:49 UTC
Message-ID: <xmqq7dr3nr9h.fsf@gitster.c.googlers.com>
In-Reply-To: <CAMP44s2bgZbKde-UFL7+sR-7QgEv5Oiho2LTi3RG7S4BD0iuaw@mail.gmail.com>

Felipe Contreras <felipe.contreras@gmail.com> writes:

Show 9 quoted lines

>> We are making life worse for the zsh users by shipping our own
>> version, aren't we?  If we didn't ship our own completion script for
>> them, the user did not have to remove the one "which is considerably
>> less complete/capable".
>
> No. You are assuming the opinion of one user in Stack Overflow is a fact.
>
> There's a reason people prefer to use Git's official completion, and
> there's a reason I wrote the wrapper.

Do you mean by "the wrapper" the 'gitfast' one you offer in the oh-my-zsh collection? If so, yes, I agree that 'gitfast' as "maybe less complete but usably faster auto-completer" is a good thing for end-users to have as an alternative to the Zsh default.

But that was not the point I was raising. I was saying that it was not making life better for them that we are posing as a valid third choice in that competition.

Your "wrapper" can still be updated regularly to the latest to grab the bash completion part from "git.git". To the Zsh audience, however, it would be more straight-forward if the choices were "there is Zsh default completion, but if you want to use a different/better version, grab 'gitfast' from the oh-my-zsh collection" than "you can use Zsh default, or you can install 'gitfast' in the way Zsh users are accustomed to from the oh-my-zsh collection, or you can manually install from git.git". After all, the latter two would give them the same thing.

It may be a good idea to leave a message in contrib/completion that nudges people toward 'gitfast' as an alternative for thowe who want to use something other than the default Zsh autocompletion.

Doing so would remove one level of unnecessary middleman (that is us) from the picture and make it simpler for end-users by reducing the number of choices from three to two.

Show 5 quoted lines

> They prioritize completeness over usability.
> ...
> No. Those people don't care if their completion is unusable.
> ...
> This is not possible, as the Zsh maintainers don't care about usability.

I think our code of conduct applies to derogatory statements made on even those who do not regularly appear in this community. If you want to attack them, please don't do it here. Thanks.