git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] commit.c: don't persist substituted parents when unshallowing

From
Junio C Hamano <gitster@pobox.com>
Date
Jul 8, 2020, 20:55 UTC
Message-ID
<xmqqk0zd20cf.fsf@gitster.c.googlers.com>
In-Reply-To
<20200708054112.GA118756@google.com>
Jonathan Nieder <jrnieder@gmail.com> writes:
Show 8 quoted lines
> A fairly straightforward test that demonstrates the bug being fixed and
> only relies on what was set up in the initial 'setup' test (4 commits).
> Thanks for tying that loose end.
>
> With or without commit message tweaks along the lines described above,
> Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>
>
> Thanks for your thoughtful work, as always.

Thanks for a nicely written review. It would be very nice if we can see a reroll before I have to tag -rc0.

Thanks.
Previous: Jonathan NiederNext: Taylor Blau
Message 7 of 8 in “commit.c: don't persist substituted parents when unshallowing”
  1. commit.c: don't persist substituted parents when unshallowingTaylor Blau, Jul 7, 2020
  2. Taylor BlauJul 7, 2020
  3. commit.c: don't persist substituted parents when unshallowingTaylor Blau, Jul 8, 2020
  4. Jonathan NiederJul 9, 2020
  5. Junio C HamanoJul 9, 2020
  6. Jonathan NiederJul 8, 2020
  7. Junio C HamanoJul 8, 2020
  8. Taylor BlauJul 8, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.