From: Junio C Hamano Date: Wed, 08 Jul 2020 20:55:28 GMT Subject: Re: [PATCH] commit.c: don't persist substituted parents when unshallowing Message-ID: In-Reply-To: <20200708054112.GA118756@google.com> Jonathan Nieder writes: > A fairly straightforward test that demonstrates the bug being fixed and > only relies on what was set up in the initial 'setup' test (4 commits). > Thanks for tying that loose end. > > With or without commit message tweaks along the lines described above, > Reviewed-by: Jonathan Nieder > > Thanks for your thoughtful work, as always. Thanks for a nicely written review. It would be very nice if we can see a reroll before I have to tag -rc0. Thanks.