Re: [PATCH] commit.c: don't persist substituted parents when unshallowing
- From
Taylor Blau <me@ttaylorr.com>
- Date
- Jul 8, 2020, 21:22 UTC
- Message-ID
- <20200708212210.GA17015@syl.lan>
- In-Reply-To
- <xmqqk0zd20cf.fsf@gitster.c.googlers.com>
On Wed, Jul 08, 2020 at 01:55:28PM -0700, Junio C Hamano wrote:
Show 13 quoted lines
> Jonathan Nieder <jrnieder@gmail.com> writes: > > > A fairly straightforward test that demonstrates the bug being fixed and > > only relies on what was set up in the initial 'setup' test (4 commits). > > Thanks for tying that loose end. > > > > With or without commit message tweaks along the lines described above, > > Reviewed-by: Jonathan Nieder <jrnieder@gmail.com> > > > > Thanks for your thoughtful work, as always. > > Thanks for a nicely written review. It would be very nice if we can > see a reroll before I have to tag -rc0.
Of course! I just sent one here[1]. Sorry for the last-minute addition to -rc0, and thanks for fast-tracking it down.
> Thanks.
Thanks, Taylor
[1]: https://lore.kernel.org/git/1f769bbbb4f1b4ad67d29ee7b3e5282446e4cc0f.1594242582.git.me@ttaylorr.com/