Re: [PATCH v2 0/3] Unify trailers formatting logic for pretty.c and ref-filter.c

From: Junio C Hamano <gitster@pobox.com>
Date: Jan 30, 2021, 01:17 UTC
Message-ID: <xmqqk0rvql3a.fsf@gitster.c.googlers.com>
In-Reply-To: <pull.726.v2.git.1611954543.gitgitgadget@gmail.com>

"Hariom Verma via GitGitGadget" <gitgitgadget@gmail.com> writes:

Show 14 quoted lines

> Currently, there exists a separate logic for %(trailers) in "pretty.{c,h}"
> and "ref-filter.{c,h}". Both are actually doing the same thing, why not use
> the same code for both of them?
>
> This is the 2nd version of the patch series that I sent few months back. It
> is focused on unifying the "%(trailers)" logic for both 'pretty.{c,h}' and
> 'ref-filter.{c,h}'. So, we can have one logic for trailers.
>
> v2 changes:
>
>  * Contains Improvements as suggested by "René Scharfe" l.s.r@web.de 1
>    [https://public-inbox.org/git/bf4423d5-c0ee-6bef-59ff-fcde003ec463@web.de/]
>  * A new trailer option was introduced to pretty.c when I was absent i.e
>    "key_value_separator". Updated the patch series with latest changes.

ref-filter.c:74:3: error: symbol 'ref_trailer_buf' was not declared. Should it be static?
    SP refs/packed-backend.c
    SP refs/ref-cache.c

For now, I've queued this on the tip of the topic while queuing; running "make SPARSE_FLAGS=-Wsparse-error sparse" before sending your series out may reduce embarrassment in the future.

Thanks.

 ref-filter.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/ref-filter.c b/ref-filter.c
index 2b1c61eadf..0e414765c1 100644
--- a/ref-filter.c
+++ b/ref-filter.c
@@ -67,7 +67,7 @@ struct refname_atom {
 	int lstrip, rstrip;
 };
 
-struct ref_trailer_buf {
+static struct ref_trailer_buf {
 	struct string_list filter_list;
 	struct strbuf sepbuf;
 	struct strbuf kvsepbuf;

-- 
2.30.0-540-g714779256f