Re: [PATCH v3 3/3] ref-filter: use pretty.c logic for trailers

From: Junio C Hamano <gitster@pobox.com>
Date: Feb 7, 2021, 18:19 UTC
Message-ID: <xmqqh7mn91w2.fsf@gitster.c.googlers.com>
In-Reply-To: <CA+CkUQ9-OCiEkMDRTpyF3rp-g1mSSzn4s9MgqJZ2BJY=XJCoEw@mail.gmail.com>

Hariom verma <hariom18599@gmail.com> writes:

> So this isn't about the patch series. Question still remains the same.

Thanks for digging the history.

Show 7 quoted lines

> Why extra blank line?
> Let's dig a bit.
> Ah. I guess I found the reason. It's due to `putchar('\n');` in
> `show_ref_array_item() [1]`. It puts a new line after each ref item.
>
> Do you want me to include a patch to get rid of this "extra blank
> line" for trailers in "for-each-ref"?

I do not know the answer to the last question, because we haven't learned the original reason why we decided to add the extra blank line after the trailer output. Even though I find it unnecessary, the code that adds it must have been written with a good reason to do so, and I do not want to see us remove the "\n" without knowing that reason.

Thanks.