Re: [PATCH v3 3/3] ref-filter: use pretty.c logic for trailers
- From
Hariom verma <hariom18599@gmail.com>
- Date
- Feb 8, 2021, 17:07 UTC
- Message-ID
- <CA+CkUQ_cdUmuP+_yUeCytn=6cc8SjMBE1aTLzWJL-U_V01uzog@mail.gmail.com>
- In-Reply-To
- <xmqqlfbz7i7i.fsf@gitster.c.googlers.com>
Hi,
On Mon, Feb 8, 2021 at 1:39 AM Junio C Hamano <gitster@pobox.com> wrote:
Show 14 quoted lines
> > If we agree that the current behaviour is *not* sensible, then we > can. On the "log --pretty" side, we have "terminator semantics" and > "separator semantics" between "tformat" and "format", when showing > more than one commits in a row, the "terminator semantics" places > one blank line after each commit we emit, while the "separator > semantics" gives one blank line between each commit pair. I think > we initially (incorrectly) used terminator semantics and our output > for two commits looked like "CommitA <blank> CommitB <blank>" before > we fixed it to use separator semantics to show "CommitA <blank> CommitB" > without the useless trailing blank line. We can apply the same principle > when "fixing" this issue to show a block of trailer lines (that is, the > change in behaviour to remove the trailing blank line turns out to > be a "fix").
I suspect that "fix" for "log --pretty" isn't going to work here.
Even if we apply the same "log --pretty"'s fix here. I think we still end up having an empty blank line between each ref item.
Thank, Hariom