Re: [PATCH 4/5] doc lint: fix bugs in, simplify and improve lint script

From: Junio C Hamano <gitster@pobox.com>
Date: Mar 28, 2021, 01:35 UTC
Message-ID: <xmqqk0psoya2.fsf@gitster.g>
In-Reply-To: <YF2+4I4rH9CQ1A2F@coredump.intra.peff.net>

Jeff King <peff@peff.net> writes:

Show 22 quoted lines

> On Fri, Mar 26, 2021 at 11:36:49AM +0100, Ævar Arnfjörð Bjarmason wrote:
>
>>  lint-docs::
>> -	$(QUIET_LINT)$(PERL_PATH) lint-gitlink.perl
>> +	$(QUIET_LINT)$(PERL_PATH) lint-gitlink.perl \
>> +		--section=1 $(MAN1_TXT) \
>> +		--section=5 $(MAN5_TXT) \
>> +		--section=7 $(MAN7_TXT)	\
>> +		--to-lint $(ALL_TXT)
>
> This is probably bikeshedding, but I would have expected the invocation
> to be:
>
>   link-gitlink.perl \
>     $(HOWTO_TXT) $(INCLUDE_TARGETS_TXT) \
>     --section=1 $(MAN1_TXT) \
>     --section=5 $(MAN5_TXT) \
>     --section=7 $(MAN7_TXT)
>
> I.e., list each filename only once, with the previous --section giving
> the expected section (and if before any --section, then expect no
> section).

Makes more sense than the presented patch. Optionally "--section=" could be used to cancel the section that was previously given.