Re: [PATCH 4/5] doc lint: fix bugs in, simplify and improve lint script

From: Jeff King <peff@peff.net>
Date: Mar 26, 2021, 11:00 UTC
Message-ID: <YF2+4I4rH9CQ1A2F@coredump.intra.peff.net>
In-Reply-To: <patch-4.6-5c8e8f21495-20210326T103454Z-avarab@gmail.com>

On Fri, Mar 26, 2021 at 11:36:49AM +0100, Ævar Arnfjörð Bjarmason wrote:

Show 7 quoted lines

>  lint-docs::
> -	$(QUIET_LINT)$(PERL_PATH) lint-gitlink.perl
> +	$(QUIET_LINT)$(PERL_PATH) lint-gitlink.perl \
> +		--section=1 $(MAN1_TXT) \
> +		--section=5 $(MAN5_TXT) \
> +		--section=7 $(MAN7_TXT)	\
> +		--to-lint $(ALL_TXT)

This is probably bikeshedding, but I would have expected the invocation to be:

  link-gitlink.perl \
    $(HOWTO_TXT) $(INCLUDE_TARGETS_TXT) \
    --section=1 $(MAN1_TXT) \
    --section=5 $(MAN5_TXT) \
    --section=7 $(MAN7_TXT)

I.e., list each filename only once, with the previous --section giving the expected section (and if before any --section, then expect no section).

-Peff