Re: [PATCH v2] git-gui - re-enable use of hook scripts

From: Junio C Hamano <gitster@pobox.com>
Date: Sep 18, 2023, 16:04 UTC
Message-ID: <xmqqjzsnmpr0.fsf@gitster.g>
In-Reply-To: <260b62dc-d45b-58fa-85c4-ffbd981a1c84@gmx.de>

Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:

Show 19 quoted lines

> Sounds good. FWIW I ran a couple experiments here, too:
>
> 	% file pathtype "C:/foo"
> 	absolute
> 	% file pathtype ".git/hooks"
> 	relative
> 	% file pathtype ".git\\hooks"
> 	relative
> 	% file pathtype "/foo"
> 	volumerelative
> 	% file pathtype "foo"
> 	relative
>
> The problem, therefore, is that `file pathtype` does not discern between a
> bare file name and a relative path. The proposed patch looks correct to
> me.
>
> Thank you,
> Johannes

Yup, the other "run hooks in a more modern way using 'git hook'" patch is the right solution for the immediate breakage, but it still cannot remove this sanitize_command_line proc as we have other users and use cases where we want to use the sanitized $PATH search, so this fix is still needed.

Thanks for a quick review on both patches.