Re: [PATCH v2] git-gui - re-enable use of hook scripts

From: Mark Levedahl <mlevedahl@gmail.com>
Date: Sep 17, 2023, 19:22 UTC
Message-ID: <fa876f80-02dc-2c04-0db3-bf3f6269b427@gmail.com>
In-Reply-To: <xmqqy1h5aisw.fsf@gitster.g>

On 9/16/23 17:51, Junio C Hamano wrote:

Show 6 quoted lines

>
> Nice.  Now we need to find a replacement maintainer for Git-gui ;-)
> In the meantime, I can queue this patch on top of what I updated
> git-gui part the last time with and merge it in.
>
> Thanks.

Thank you for help on this too. I retired some time ago, and stopped using git much a decade ago. My popping up on the list was inspired by cleaning out an old laptop and finding some old patches I thought would be useful, especially as I'd helped Shawn create some of that old git-gui/Cygwin code. My interest is unlikely to endure so I'm definitely not a good candidate to maintain git-gui.

On this hook execution problem, looking further, I find using git-hook run will fix some other issues in git-gui's hook handling, and that would actually also patch around the problem we just fixed. So, another patch follows, the commit message presumes the one fixing relative path search remains. I would suggest keeping the one fixing the relative path search regardless.

Mark