git/list[1] front-page[2] threads[3] people[4] search[5] about
 

BUG: git-gui no longer executes hook scripts

From
Mark Levedahl <mlevedahl@gmail.com>
Date
Sep 15, 2023, 16:45 UTC
Message-ID
<bd510f6d-6613-413b-6d64-c3d2fd01d8a9@gmail.com>
The commit titled "Work around Tcl's default |PATH| lookup",|aae9560, 
adds checking on all commands to be executed to assure these are on the 
PATH. Any script in .git/hooks is rejected as .git/hooks is not (in 
general) on the PATH, even if the entry in .git/hooks is a symlink to a 
file on the PATH. Instead, git-gui throws and error without completing 
the operation. This is easily demonstrated by say, enabling the 
commit-msg script (hooks-commit-msg.sample templates) and attempting a 
commit.
|
|I don't have a suggested solution to this: reverting the above commit 
will fix this problem, but that commit  was made to mitigate a security 
issue.  Perhaps anything in .git/hooks should be accepted without 
further checks?
|
|
|
|Mark
|
Next: Junio C Hamano
Message 1 of 25 in “BUG: git-gui no longer executes hook scripts”
  1. Mark LevedahlSep 15, 2023
  2. Junio C HamanoSep 15, 2023
  3. Junio C HamanoSep 15, 2023
  4. Mark LevedahlSep 15, 2023
  5. git-gui - re-enable use of hook scriptsMark Levedahl, Sep 16, 2023
  6. Junio C HamanoSep 16, 2023
  7. git-gui - re-enable use of hook scriptsMark Levedahl, Sep 16, 2023
  8. Junio C HamanoSep 16, 2023
  9. Mark LevedahlSep 17, 2023
  10. git-gui - use git-hook, honor core.hooksPathMark Levedahl, Sep 17, 2023
  11. Johannes SchindelinSep 18, 2023
  12. Junio C HamanoSep 18, 2023
  13. Mark LevedahlSep 18, 2023
  14. Junio C HamanoSep 18, 2023
  15. Pratyush YadavSep 20, 2023
  16. Mark LevedahlSep 20, 2023
  17. Junio C HamanoSep 20, 2023
  18. Junio C HamanoSep 20, 2023
  19. Johannes SchindelinSep 18, 2023
  20. Junio C HamanoSep 18, 2023
  21. Pratyush YadavSep 20, 2023
  22. Junio C HamanoSep 16, 2023
  23. Mark LevedahlSep 16, 2023
  24. Mark LevedahlSep 16, 2023
  25. Junio C HamanoSep 16, 2023

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.